On Wed, 6 May 2020 20:37:10 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> This is a toolchain upgrade on Windows from the current Visual Studio 2017 > (version 15.9.16) to Visual Studio 2019 (version 16.5.3). This will match a > recent upgrade done for JDK 15 -- see > [JDK-8244214](https://bugs.openjdk.java.net/browse/JDK-8244214). > > I have run a full build and test using this new compiler. > > NOTE: although this isn't strictly dependent on > [JDK-8244487](https://bugs.openjdk.java.net/browse/JDK-8244487), which is out > for review as PR #211 , I plan to wait until that one is approved. I will > then integrate PR #211 followed by this PR. I also think that we should remove it. If you read its history on the mailing list, it was added to the repository in part as a solution to the `WINSDK_DIR not defined` error. See the message ["Problems building openjfx"][1] on the mailing list. That discussion starts with `WINSDK_DIR`. My goal in #488 is to give developers a better chance at getting the official build under Cygwin working after hitting the error. [1]: https://mail.openjdk.java.net/pipermail/openjfx-dev/2018-November/022858.html ------------- PR: https://git.openjdk.java.net/jfx/pull/212
