On Wed, 12 May 2021 08:13:32 GMT, Florian Kirmaier <fkirma...@openjdk.org>
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> we now use a try finally statement, to make sure updateEditingIndex is
> reset!
coming nearer :) see my inline comments
modules/javafx.controls/src/main/java/javafx/scene/control/ListCell.java line
546:
> 544:
> 545: if (editing && (index == -1 || list == null || index !=
> editIndex)) {
> 546: // If my index is not the one being edited then I need to
> cancel
probably just me not being able to see at a glance if the overall logic in the
method is the exact same as before the fix (modulo the fix itself :), but: I
would prefer an extra method used in both early return for the -1/null-list and
the old else-if.
If the second reviewer sees the equivalence at a glance, I'll believe his eyes
:)
-------------
Changes requested by fastegal (Committer).
PR: https://git.openjdk.java.net/jfx/pull/441
