On Wed, 12 May 2021 08:13:32 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
>> Fixing ListCell editing status is true, when index changes while editing. > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > 8264127: > we now use a try finally statement, to make sure updateEditingIndex is > reset! Changes requested by fastegal (Committer). modules/javafx.controls/src/main/java/javafx/scene/control/ListCell.java line 342: > 340: } > 341: updateEditing(); > 342: } forgot yesterday: to keep consistent with TreeTableCell (and TreeCell), the updateEditing should be moved into the else-block (as last call) - couldn't find any difference (in fact couldn't reproduce the error the if/else is supposed to solve) as long as updateEditing behaves, though. ------------- PR: https://git.openjdk.java.net/jfx/pull/441
