On Fri, 14 May 2021 21:40:39 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added missing oldValue assignments
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/BidirectionalBinding.java
> line 585:
>
>> 583: private TypedGenericBidirectionalBinding(Property<T> property1,
>> Property<T> property2) {
>> 584: super(property1, property2);
>> 585: propertyRef1 = new WeakReference<>(property1);
>
> Don't you need to initialize `oldValue` here?
>
>
> oldValue = property1.get();
Yes, it should be initialized.
-------------
PR: https://git.openjdk.java.net/jfx/pull/454
