On Mon, 24 May 2021 11:07:12 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
> Issue: > There are several issues related to Accelerator of MenuItem of a ConextMenu > set on Control. > 1. Accelerator of ContextMenu's MenuItem is not removed when ContextMenu is > removed from Scene > 2. Accelerator is not updated correctly when the Control is removed from a > Scene and Added to a different Scene > 3. Accelerator is not removed from Scene when the anchor node is removed from > Scene and then it's ContextMenu is set to null > > Fix: > The accelerator should be added or removed correctly according to the Scene > property of the anchor node. > The issue#3 in above list is only fixed for Button and fails for other > Controls. A test is added for this scenario and I shall report a new issue to > address it. > Added tests that fails before and pass after the fix. Looks good. I left one comment on the test. When you update it to include the bug ID of the follow-on bug, I'll re-review it. modules/javafx.controls/src/test/java/test/javafx/scene/control/AcceleratorParameterizedTest.java line 352: > 350: } > 351: > 352: @Ignore("Passes only for Button") Can you file the follow-on bug and then update this comment to use that bug ID? ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/515