On Mon, 24 May 2021 11:07:12 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
> Issue: > There are several issues related to Accelerator of MenuItem of a ConextMenu > set on Control. > 1. Accelerator of ContextMenu's MenuItem is not removed when ContextMenu is > removed from Scene > 2. Accelerator is not updated correctly when the Control is removed from a > Scene and Added to a different Scene > 3. Accelerator is not removed from Scene when the anchor node is removed from > Scene and then it's ContextMenu is set to null > > Fix: > The accelerator should be added or removed correctly according to the Scene > property of the anchor node. > The issue#3 in above list is only fixed for Button and fails for other > Controls. A test is added for this scenario and I shall report a new issue to > address it. > Added tests that fails before and pass after the fix. This pull request has now been integrated. Changeset: 0ffa8e28 Author: Ambarish Rapte <ara...@openjdk.org> URL: https://git.openjdk.java.net/jfx/commit/0ffa8e2824d64b585363ae7a1a51890e1f5b9000 Stats: 125 lines in 2 files changed: 112 ins; 12 del; 1 mod 8244075: Accelerator of ContextMenu's MenuItem is not removed when ContextMenu is removed from Scene Reviewed-by: kcr, aghaisas ------------- PR: https://git.openjdk.java.net/jfx/pull/515
