On Tue, 22 Jun 2021 23:15:55 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> This PR extends data URI support to allow stylesheets to be loaded from data >> URIs. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > simplified branch in StyleManager.loadStylesheetUnPrivileged The API and spec changes look good. As I mentioned in a comment added to the CSR, it is ready to move to "Proposed". Once we are farther along in the code review, I'll formally review the CSR. One thing I noticed is that the diffs don't exactly match what you pasted in the CSR (looks like a copy/paste issue). The `Scene::setUserAgentStylesheet` and `SubScene::setUserAgentStylesheet` methods each have three unchanged lines that are marked with the `+` diff indicator. Can you double-check? I'll review the implementation next. ------------- PR: https://git.openjdk.java.net/jfx/pull/536
