> This PR fixes 2 NPEs in Choice-and ComboBox, when the selection model is null. > > ChoiceBox: > - Null check in **valueProperty()** listener > > ComboBox: > - Null check in **valueProperty()** listener > - Null check in **ComboBoxListViewSkin#updateValue()** > > The tests checks, that no NPE is printed to the console. They also checks, > that the set value is still displayed (either in the ComboBox button cell or > the ChoiceBox display label)
Marius Hanl has updated the pull request incrementally with one additional commit since the last revision: Added another cbx test + cleaned up exception handler + let the exception bubble up instead of try-catch ------------- Changes: - all: https://git.openjdk.java.net/jfx/pull/557/files - new: https://git.openjdk.java.net/jfx/pull/557/files/a47c0652..0b631ed4 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=557&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=557&range=01-02 Stats: 44 lines in 2 files changed: 29 ins; 12 del; 3 mod Patch: https://git.openjdk.java.net/jfx/pull/557.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/557/head:pull/557 PR: https://git.openjdk.java.net/jfx/pull/557
