On Wed, 7 Jul 2021 11:04:27 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added another cbx test + cleaned up exception handler + let the exception >> bubble up instead of try-catch > > modules/javafx.controls/src/main/java/javafx/scene/control/ComboBox.java line > 244: > >> 242: if (getItems() == null) return; >> 243: SelectionModel<T> sm = getSelectionModel(); >> 244: if (sm == null) return; > > Do we need similar null check in editableProperty() listener below? Yes. I just focused on the value but you are right, we should add it there as well. Will update my PR and also document it in the ticket. ------------- PR: https://git.openjdk.java.net/jfx/pull/557
