On Fri, 9 Jul 2021 10:51:16 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
> > Do we wanna create follow-ups for this, so this PR won''t get any bigger? > > That would be at least my preference. > > Right now I see: > > ``` > > * !isEditing check in cancelEdit() (we can return directly) > > > > * isEditing check in startEdit() (we can return directly) > > ``` > > > > > > > > > > > > > > > > > > > > > > > > Is there more? > > just checked my notes (there's a cell-editing branch in my fork where I'm > experimenting) - astonishingly the answer is no, could not see anything :) > And actually, seems like we don't even need to return immediately: would have > expected some unhealthy side-effects on doing the switching into visual > editing state more than once, but couldn't detect anything. You might try, > though :) Okay. Question is, should we guard against a double edit? There is already one in `TreeTableCell#startEdit`, but probably forgotten in TableCell. I think it makes sense and as there is already the check in TreeTableCell, there was at least a thought of it somewhere in the past. If there is nothing left, should I create a ticket for `startEdit` and for `cancelEdit` (this only affects the sub classes) ? :) ------------- PR: https://git.openjdk.java.net/jfx/pull/569
