On Mon, 16 Aug 2021 17:09:25 GMT, Marius Hanl <mh...@openjdk.org> wrote:

>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListCellStartEditTest.java
>>  line 75:
>> 
>>> 73:         this.listCell = listCell;
>>> 74:     }
>>> 75: 
>> 
>> this hit me when trying separate out the (accidentally?) single test method: 
>> all tests work on the same instance of the cell, so its state is 
>> unpredictable. Instead, parameterize on a supplier and let it provide a new 
>> cell in setup.
>
> I see, another point where I would love we actually use JUnit5. :/

ehh .. this is not resolved - still change required - or what do I miss?

-------------

PR: https://git.openjdk.java.net/jfx/pull/569

Reply via email to