On Thu, 8 Jul 2021 21:05:51 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java >> line 324: >> >>> 322: >>> 323: comboBox.layout(); >>> 324: >> >> KISS again :) >> >> - buttonCell is unrelated >> - setting the value is a not immediately obvious trigger of the NPE >> - the test relies on the fact that the combo's skin is installed in setup - >> when installing it later, we'd run into a NPE at a different location in code >> >> but then, this might be something to remember for a future bug/fix, if we >> agree on not including the list/combo sync into this bug > > ButtonCell strikes again. 😄 I will remove it. > Hm, this sounds like a follow-up then. Should I test this and create one? > > EDIT: I think it's not wrong to check the button cell. But I guess you may > want to see another check, but then again, I don't know what should I check > for. > We should expect that the value is still shown in the button cell after an > editable change (and ofc selectionModel null) the buttonCell state is simply irrelevant here, what's striking - you - again is a test without final assert :) Same as toggling editability. ------------- PR: https://git.openjdk.java.net/jfx/pull/557
