> The bug is a regression as a result of fix done for JDK-8227366 and is 
> reproducible on Linux and Mac. This fix is being reverted in this change and 
> a new bug (JDK-8271054) has been created to redo the JDK-8227366
> 
> An automated testcase is being added to make sure similar regression is not 
> introduced when working on the redo bug. The automated testcase fails without 
> the current change and passes after the change.
> 
> The testcase works fine on Mac and Linux, but I see some issues in windows. 
> The stage is minimised after calling stage.show without calling 
> stage.setAlwaysOnTop(true). I see that there are other tests like 
> DualWindowsTest.java which are failing for same reason. Also, if I remove the 
> stage.setAlwaysOnTop(true) from tests like 
> FocusParentWindowOnChildCloseTest.java,  the stage remains minimised there as 
> well. This seems wrong as calling stage.setAlwaysOnTop(true) should not be 
> required to bring stage window in focus on running the test. This may be an 
> issue on my Window machine or something similar. I hope reviewers can shed 
> some light on this.

Pankaj Bansal has updated the pull request incrementally with one additional 
commit since the last revision:

  Fixed review comments 1) Increase delay 2) Fix Formatting 3) Make test stable 
on Windows according to suggestions

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/581/files
  - new: https://git.openjdk.java.net/jfx/pull/581/files/6d727cd4..623c3930

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=581&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=581&range=00-01

  Stats: 20 lines in 1 file changed: 16 ins; 1 del; 3 mod
  Patch: https://git.openjdk.java.net/jfx/pull/581.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/581/head:pull/581

PR: https://git.openjdk.java.net/jfx/pull/581

Reply via email to