> It seems raw images need to be converted BRGA -> RGBA.
> 
> It was being converted on gtk2 code path, but gtk3 only uses 
> `gtk_drag_set_icon_pixbuf`.
> 
> I have simplified the gtk2 `DragView::View::expose` to paint with 
> `gdk_cairo_set_source_pixbuf` (that is available since Gtk 2.8) because the 
> old way was somehow converting  again.
> 
> Run the issue sample with `-Djdk.gtk.version=2` to test the gtk2 code path.
> 
> To test:
> 
> `./gradlew apps`
> 
> 
> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar 
> dragdrop.DragDropWithControls
> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar 
> dragdrop.DragDropColor 
> 
> java -Djdk.gtk.version=2 @build/run.args -cp 
> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls
> java -Djdk.gtk.version=2 @build/run.args -cp 
> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor

Thiago Milczarek Sayao has updated the pull request incrementally with one 
additional commit since the last revision:

  Change test to manual

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/599/files
  - new: https://git.openjdk.java.net/jfx/pull/599/files/5530488c..4509462a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=599&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=599&range=01-02

  Stats: 254 lines in 2 files changed: 83 ins; 171 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/599.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/599/head:pull/599

PR: https://git.openjdk.java.net/jfx/pull/599

Reply via email to