On Mon, 23 Aug 2021 14:10:56 GMT, Christian Stein <cst...@openjdk.org> wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8267472 > > Christian Stein has updated the pull request incrementally with one > additional commit since the last revision: > > Pass module version also to `jmod` I think there may be two other tasks where the `--module-version` is needed: [:graphics:compileFullJava](https://github.com/openjdk/jfx/blob/e9eabd0dbd305a860b8083daf5229764a290e9ef/build.gradle#L2208) and [:web:compileJavaDOMBindingTask](https://github.com/openjdk/jfx/blob/e9eabd0dbd305a860b8083daf5229764a290e9ef/build.gradle#L3603). build.gradle line 3929: > 3927: options.compilerArgs.addAll([ > 3928: '-implicit:none', > 3929: '--module-version', "$RELEASE_VERSION_SHORT", I'm not sure this is needed (although it doesn't hurt), since the shims are only used for testing and are not included in any jar file. ------------- PR: https://git.openjdk.java.net/jfx/pull/608
