On Mon, 23 Aug 2021 14:06:31 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Pass module version also to `jmod`
>
> build.gradle line 3929:
> 
>> 3927:             options.compilerArgs.addAll([
>> 3928:                 '-implicit:none',
>> 3929:                 '--module-version', "$RELEASE_VERSION_SHORT",
> 
> I'm not sure this is needed (although it doesn't hurt), since the shims are 
> only used for testing and are not included in any jar file.

Seeing version information in stack traces of failed tests can be helpful. ;-)

-------------

PR: https://git.openjdk.java.net/jfx/pull/608

Reply via email to