On Mon, 14 Jun 2021 11:05:25 GMT, Andreas Heger <github.com+85555697+andreas-he...@openjdk.org> wrote:
>> @andreas-heger Welcome to the `jfx` project. At a quick glance, the fix >> looks promising. Have you tested this on Windows with Hi-DPI to make sure >> there is no impact? Would you be able add an automated test case that fails >> (only on Mac retina) without the fix and passes (on all platforms) with your >> fix? Hi-DPI fixes are often tricky to test in an automated test, so if not, >> we can use the existing manual test. >> >> @nlisker this is the same problem I noted while testing PR #334. Clearly I >> had forgotten that it was not only a preexisting bug, but a known bug that >> was already filed. I intend to test this alone and in connection with your >> PR. > > @kevinrushforth >> The fix looks good. I tested it both in isolation and with PR #334 and it >> works on both a retina and non-retina display. >> >> If you have time to write an automated test, that would be useful, but if >> not then a manual test would be OK. > > Ok, I will try to write an automated test case which draws a sphere in a > SubScene and then calculates the average color of the generated image. The > test will be passed if the calculated average does not differ from the > excepted average color by a certain tolerance value. I'm not sure if I will > manage to do this... but I will give it a try. @andreas-heger are you able to come up with an automated test for this bug? ------------- PR: https://git.openjdk.java.net/jfx/pull/531
