On Mon, 25 Oct 2021 22:53:53 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix review comments > > modules/javafx.controls/src/main/java/javafx/scene/control/PopupControl.java > line 179: > >> 177: * HTML element. Note that, like the HTML style attribute, this >> 178: * variable contains style properties and values and not the >> 179: * selector portion of a style rule. > > It would be good to add a sentence here with the information (which was > formerly in the getter) that a value of `null` is converted to the empty > string. Added. > modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line > 508: > >> 506: * <p>The maximum height of the tabs in the TabPane.</p> >> 507: * @return the maximum height of the tabs >> 508: */ > > In reverting this, you introduced a whitespace (indentation) change. Fixed. ------------- PR: https://git.openjdk.java.net/jfx/pull/646
