On Thu, 28 Oct 2021 23:30:32 GMT, Kevin Rushforth <[email protected]> wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/PopupControl.java
> line 1132:
>
>> 1130: * Constructor for subclasses to call.
>> 1131: */
>> 1132: protected CSSBridge() {
>
> Please revert this change. Since the class is protected, it's a compatible
> change, but any change to a method's signature, return type, or modifiers
> needs a CSR.
Oh! never mind. I misread this. I see that you _are_ reverting it back. That's
good then (and a good catch).
-------------
PR: https://git.openjdk.java.net/jfx/pull/646
