On Fri, 29 Oct 2021 20:26:56 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changed javadoc > > modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextBinding.java > line 188: > >> 186: int i = 0; >> 187: >> 188: // Parse the input string and stop after the first mnemonic. > > This seems to do much more than just fixing numeric mnemonics. Now it stops > after the first mnemonic, whereas it picked the last mnemonic before this > change (which seems to be a regression from what happened in jfx16). > > I think the regression should be fixed first, then additional features can be > added? This PR does not add any additional feature. It restores the behavior of jfx16, where any character is acceptable as a mnemonic, and the first mnemonic is selected. ------------- PR: https://git.openjdk.java.net/jfx/pull/647
