On Fri, 17 Dec 2021 13:33:57 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a link to the mailing list in the section regarding contributing bug >> fixes. >> 3. Remove the text about cross-linking the PR and JBS issue, and add a note >> that the Skara tooling takes care of this >> 4. Remove the section about manually resolving the JBS issue, and add a note >> that the Skara bot automatically does this when the PR is integrated. >> 5. Suggest the use of the "/reviewers 2" and "/csr" commands when appropriate >> 6. Update the note regarding which JDK(s) to use. > > Kevin Rushforth has updated the pull request incrementally with one > additional commit since the last revision: > > Minor updates CONTRIBUTING.md line 18: > 16: ---------------- > 17: > 18: If you find yourself wishing for a feature that doesn't exist in OpenJFX, > you are probably not alone. There are bound to be others out there with > similar needs. Many of the features that OpenJFX has today have been added > because our users saw the need. I think you should restore this sentence. It feels uplifting and encouraging, while the other added sections feel pretty discouraging at first sight for newcomers to the project. ------------- PR: https://git.openjdk.java.net/jfx/pull/303
