On Fri, 17 Dec 2021 14:15:32 GMT, Nir Lisker <nlis...@openjdk.org> wrote:

>> Kevin Rushforth has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Minor updates
>
> CONTRIBUTING.md line 204:
> 
>> 202: section of the Code Review Policies doc, we also need a 
>> [CSR](https://wiki.openjdk.java.net/display/csr/Main), which documents the 
>> API change and its approval.
>> 203: The CSR can be reviewed in parallel. Changes in the API that arise 
>> during the review need to be reflected in the CSR, meaning
>> 204: that the final review / approval of the CSR usually happens late in the 
>> review cycle.
> 
> I would advise contributors to not deal with the CSR until the review is 
> almost done. It just duplicates the places that you need to update. I'm 
> saying this from personal experience :)

Good idea.

-------------

PR: https://git.openjdk.java.net/jfx/pull/303

Reply via email to