On Sat, 19 Feb 2022 14:32:46 GMT, Kevin Rushforth <[email protected]> wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update test case for line straightness check
>
> tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.java line
> 78:
>
>> 76: launchLatch.countDown();
>> 77: }
>> 78: }
>
> Add a blank after this.
done
> tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.java line
> 87:
>
>> 85: }
>> 86:
>> 87:
>
> Minor: the extra blank line is unnecessary.
done
> tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.java line
> 105:
>
>> 103: Platform.runLater(() -> {
>> 104: webView = new WebView();
>> 105: Scene scene = new Scene(webView,80,60);
>
> This test passes on my Windows system even without the fix. Based on what I
> see on the screen, I think its because the scene size is too small. I would
> make it larger (at least 150x100).
>
> Minor: add a space after the commas to separate the args
space added, i will look this observation on windows
-------------
PR: https://git.openjdk.java.net/jfx/pull/731
