On Mon, 21 Feb 2022 06:02:32 GMT, Jay Bhaskar <d...@openjdk.java.net> wrote:
>> Issue: The end point of line in drawLinesForText , add thickness to the
>> endPoint.y(). In this case origin which is start point and the end point
>> would not be same, and line would be drawn not straight.
>> Solution: Do not add thickness to the y position of end point of line.
>> Start Point(x,y) ----------End Point(x + width, 0)
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Improve style and width iterartion logic
I added one more minor formatting comment. The important points are listed as
replies to your earlier comments above: The size of the window needs to be
larger, and the sampling logic isn't quite right.
tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.java line 172:
> 170: continue;
> 171: }
> 172: else {
Minor: this should be on one line, like this:
} else {
Alternatively, you can replace the entire if-then-else block with:
assertEquals("Pixel color does not match", expected_line_color,
actual_line_color);
-------------
PR: https://git.openjdk.java.net/jfx/pull/731
