On Tue, 8 Mar 2022 20:57:53 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix wrong test values
>
> modules/javafx.base/src/test/java/test/javafx/beans/value/ObservableValueFluentBindingsTest.java
> line 379:
>
>> 377: @Test
>> 378: void shouldReturnPropertyValuesWithOperationApplied() {
>> 379: assertEquals("UNKNOWN",
>> observableValue.getValue()); // initially it is not left or right, so
>> unknown
>
> Maybe these comments should be in the `String message` argument? I don't mind
> either way.
I've left these as is, I don't find the messages in asserts particularly useful
unless they describe which parameters are used when the assert is used in a
parameterized test or a loop. I added the comments more to help readers of the
code what the thought process was behind the test, not so much to describe the
error.
-------------
PR: https://git.openjdk.java.net/jfx/pull/675
