On Tue, 10 May 2022 20:03:08 GMT, Marius Hanl <mh...@openjdk.org> wrote:
> A common reason for using the `TextFormatter` is the need for a `filter`.
> Therefore, the following constructor is typically used:
> `public TextFormatter(@NamedArg("filter") UnaryOperator<Change> filter) { ...
> }`
>
> With that, no `valueConverter` is set in the `TextFormatter`.
>
> When a `TextField` will commit his value, `TextFormatter.updateValue(...)` is
> called.
> Since `valueConverter` is null, an NPE is thrown and catched inside it and
> `TextFormatter.updateText()` is called (which will call
> `TextInputControl.updateText(...)`), which won't do anything either since
> `valueConverter` is still not set (=null).
>
> A minor improvement here is to just skip `TextFormatter.updateValue(...)` and
> therefore `TextFormatter.updateText()` (->
> `TextInputControl.updateText(...)`), since this methods won't do anything
> without a `valueConverter`.
> With that change, no exception (NPE) is thrown and catched, and therefore
> also exception breakpoints are not called (can be annoying ;)).
> This will also slightly increase the performance, as throwing exceptions is a
> (minor) bottleneck.
>
> Added tests for all `TextFormatter` functionalities, which pass before and
> after.
This pull request has now been integrated.
Changeset: 81e1cc3e
Author: Marius Hanl <mh...@openjdk.org>
Committer: Kevin Rushforth <k...@openjdk.org>
URL:
https://git.openjdk.java.net/jfx/commit/81e1cc3edcbfda34479ee876cbd9eb74099a7e57
Stats: 78 lines in 2 files changed: 75 ins; 0 del; 3 mod
8286552: TextFormatter: UpdateValue/UpdateText is called, when no
ValueConverter is set
Reviewed-by: kcr
-------------
PR: https://git.openjdk.java.net/jfx/pull/794
