On Mon, 8 Aug 2022 21:58:40 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect >> statement "Is functionally equivalent to calling >> <code>getSelectedIndices().contains(index)</code>." >> 2. reimplement TableView.TableViewSelectionModel.isSelected(int) method to >> return true when at least one cell in *any* column is selected on the given >> row (was: *all* columns) >> 3. change selectRowWhenInSingleCellSelectionMode() and >> selectRowWhenInSingleCellSelectionMode2() in TableViewSelectionModelImplTest >> to reflect new reality. >> >> NOTE: proposed change alters semantics of isSelected(int) method (in the >> right direction, in my opinion). > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > 8235491: delegate to super() I would lean towards creating a new issue, unless one of the three you listed above is a natural fit. ------------- PR: https://git.openjdk.org/jfx/pull/839
