On Fri, 12 Aug 2022 17:21:24 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect >> statement "Is functionally equivalent to calling >> <code>getSelectedIndices().contains(index)</code>." >> 2. reimplement TableView.TableViewSelectionModel.isSelected(int) method to >> return true when at least one cell in *any* column is selected on the given >> row (was: *all* columns) >> 3. change selectRowWhenInSingleCellSelectionMode() and >> selectRowWhenInSingleCellSelectionMode2() in TableViewSelectionModelImplTest >> to reflect new reality. >> >> NOTE: proposed change alters semantics of isSelected(int) method (in the >> right direction, in my opinion). > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > 8235491: added tests long journey with a good end :) Looks fine, verified tests: - some assertions needed to be adjusted to the fix, so they were passing before and still passing after the fix - some where failing/passing before/after the fix ------------- Marked as reviewed by fastegal (Reviewer). PR: https://git.openjdk.org/jfx/pull/839
