On Tue, 19 Jul 2022 22:08:19 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect > statement "Is functionally equivalent to calling > <code>getSelectedIndices().contains(index)</code>." > 2. reimplement TableView.TableViewSelectionModel.isSelected(int) method to > return true when at least one cell in *any* column is selected on the given > row (was: *all* columns) > 3. modified TreeTableRow.updateSelection() to use the right isSelected() > method > 4. updated tests for Tree/TableView > > NOTE: proposed change alters semantics of isSelected(int) method (in the > right direction, in my opinion). This pull request has now been integrated. Changeset: 7cb8d679 Author: Andy Goryachev <ango...@openjdk.org> Committer: Kevin Rushforth <k...@openjdk.org> URL: https://git.openjdk.org/jfx/commit/7cb8d679dc2aa96b7c9a2bd60983ab74aa275967 Stats: 325 lines in 8 files changed: 285 ins; 9 del; 31 mod 8235491: Tree/TableView: implementation of isSelected(int) violates contract Reviewed-by: aghaisas, fastegal, kcr ------------- PR: https://git.openjdk.org/jfx/pull/839
