On Fri, 9 Sep 2022 21:13:25 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> Modified the tree/table view internals to suppress the horizontal (a.k.a. > breadth in VirtualFlow) scroll bar when a constrained resize mode is in > effect. This change complements fixes added in > [JDK-8089009](https://bugs.openjdk.org/browse/JDK-8089009) without addressing > other bugs found in https://bugs.openjdk.org/browse/JDK-8292810 > > This PR might need a CSR since a public method is added to VirtualFlow: > > > /** > * Suppresses the breadth bar from appearing. > */ > public void setSuppressBreadthBar(boolean suppress) { > this.suppressBreadthBar = suppress; > } Both of the two implementation methods can be made package-scope, since they are not used outside the package (so no need for accessors or anything else complicated to hide the details). Is it feasible to provide a unit test for this? modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableViewSkinBase.java line 898: > 896: } > 897: > 898: protected void updateSuppressBreadthBar() { This should be package-scope. modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 2383: > 2381: * Suppresses the breadth bar from appearing. > 2382: */ > 2383: public void setSuppressBreadthBar(boolean suppress) { This should be package-scope. ------------- Changes requested by kcr (Lead). PR: https://git.openjdk.org/jfx/pull/894
