On Mon, 12 Sep 2022 15:26:58 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java >> line 307: >> >>> 305: private boolean needLengthBar; >>> 306: private boolean tempVisibility = false; >>> 307: private boolean suppressBreadthBar; >> >> Suggestion (optional) : You might want to explicitly initialize this to >> `false`, since we rely on this for other controls (e.g., `ListView`) which >> don't call `setSuppressBreadthBar`. (yes, I know Java will initialize it to >> false anyway, but setting it explicitly could be helpful to a reader of the >> code) > > I would argue otherwise: not only it adds visual noise, but any time one > steps into the constructor in a debugger, it goes through every field > assignment. I don't see it as visual noise (and don't really care about the minor impact on the debugger), but not a big deal either way. I'll re-approve it now. ------------- PR: https://git.openjdk.org/jfx/pull/894
