On Thu, 29 Sep 2022 15:58:01 GMT, Andy Goryachev <[email protected]> wrote:

>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>
> Andy Goryachev has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 20 additional 
> commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 8290844.skin.install
>  - 8290844: unit tests
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: review comments
>  - 8290844: review comments
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: review comments
>  - 8290844: review comments
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: javadoc
>  - ... and 10 more: https://git.openjdk.org/jfx/compare/d3accb42...d954aafc

This looks good now, although I want to do a little more testing before 
approving it.

The next step is to update the CSR with the latest doc changes. For the 
existing methods and class docs that have been modified, please show the diffs 
to make it easier to see what is changed.

-------------

PR: https://git.openjdk.org/jfx/pull/845

Reply via email to