On Tue, 4 Oct 2022 19:08:23 GMT, Andy Goryachev <[email protected]> wrote:
>> Good point. We have a tension between "pure OO" and giving clear advice. In >> the case of `Skin`, there are only two direct subclasses, so we could call >> that out here and say that `Control` enforces a 1-to-1 relationship, but >> `PopupControl` does not. Alternatively, we could change this to say that >> "Some implementations of Skinnable define a 1-to-1 relationship...". That >> would key developers to look for that in the the documentation of the >> implementing class. >> >> Which way do you think is best? > > I like "Some implementations of Skinnable define a 1-to-1 relationship..."... I re-phrased the javadoc, please see if it's clearer. ------------- PR: https://git.openjdk.org/jfx/pull/845
