On Tue, 11 Oct 2022 21:07:34 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8287822: [macos] Remove support of duplicated formats from macOS [v2] > > modules/javafx.media/src/main/java/com/sun/media/jfxmediaimpl/platform/gstreamer/GSTMedia.java > line 95: > >> 93: String contentType, >> 94: long sizeHint, >> 95: long[] nativeMediaHandle); > > This file contains whitespace-only changes. Maybe revert the file since it is > otherwise unchanged? Reverted. > modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFMediaPlayer.mm > line 89: > >> 87: >> 88: // Max number of bytes we will provide per request >> 89: #define MAX_READ_SIZE 1048576 > > Optional suggestion: define this as `(1024 * 1024)` ? It's OK to leave it as > is if you prefer. Maybe add a comment in that case? Fixed. > modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFMediaPlayer.mm > line 779: > >> 777: >> 778: // Do not provide more then MAX_READ_SIZE at one call, otherwise >> 779: // AVFoundation might fail if we providing too much data. > > Minor: "providing" --> "provide" Fixed. > tests/manual/media/FXMediaPlayer/src/fxmediaplayer/media/FXMedia.java line > 141: > >> 139: } >> 140: >> 141: } > > Minor: missing newline at end of file. Fixed. ------------- PR: https://git.openjdk.org/jfx/pull/909
