On Thu, 13 Oct 2022 22:24:06 GMT, Andy Goryachev <[email protected]> wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8287822: [macos] Remove support of duplicated formats from macOS [v3]
>
> tests/manual/media/FXMediaPlayer/src/fxmediaplayer/media/FXMedia.java line
> 118:
>
>> 116: path = fileSystem.getPath("fxmediaplayer", "media");
>> 117: } else {
>> 118: path = Path.of(uri);
>
> should we explicitly check if it is a file?
> if("file".equals(uri.getScheme()) { ...
I do not see a point of doing it, since it should be a file.
-------------
PR: https://git.openjdk.org/jfx/pull/909
