On Sat, 22 Oct 2022 07:49:12 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
> See https://bugs.openjdk.org/browse/JDK-8221708 The new changes look good. I get a bogus error marker on the apps folder in Project Explorer, but in Package Explorer there is no error. Looks like some Eclipse hiccup. My only comment is about some classpath files that define more dependencies than needed. For example, manualTests-dnd can use this: <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/swing"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry excluding=".classpath|.project" kind="src" output="bin" path=""/> <classpathentry kind="output" path="bin"/> </classpath> Everything still works with the extra dependencies, but in general it's better to remove them. Do you want to do that? I can find the minimal dependencies. ------------- PR: https://git.openjdk.org/jfx/pull/930
