On Mon, 7 Nov 2022 08:32:22 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708 > > John Hendrikx has updated the pull request incrementally with one additional > commit since the last revision: > > Update Eclipse classpath files > > - Stripped dependencies to a minimum > - Added ".settings" to exclusion for projects with sources in root > folder Some projects under tests have a lot of `add-exports` attributes that are not required. Leaving them doesn't cause trouble, but there's no reason to have them. I supplied a corrected .classpath file in all cases that you can use, or, you can remove them manually. Note that `systemTests-test` does require the `add-exports` attributes. After this change the PR can be committed. tests/manual/UI/.classpath line 29: > 27: <classpathentry excluding=".classpath|.project|.settings" kind="src" > output="bin" path=""/> > 28: <classpathentry kind="output" path="bin"/> > 29: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry excluding=".classpath|.project|.settings" kind="src" output="bin" path=""/> <classpathentry kind="output" path="bin"/> </classpath> tests/manual/controls/.classpath line 29: > 27: <classpathentry excluding=".classpath|.project|.settings" kind="src" > output="bin" path=""/> > 28: <classpathentry kind="output" path="bin"/> > 29: </classpath> No need for all the "add exports". This is enough: <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry excluding=".classpath|.project|.settings" kind="src" output="bin" path=""/> <classpathentry kind="output" path="bin"/> </classpath> tests/manual/desktop/.classpath line 29: > 27: <classpathentry kind="src" output="bin" path="HostServices"/> > 28: <classpathentry kind="output" path="bin"/> > 29: </classpath> Same: <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="src" output="bin" path="HostServices"/> <classpathentry kind="output" path="bin"/> </classpath> tests/manual/dnd/.classpath line 34: > 32: <classpathentry excluding=".classpath|.project|.settings" kind="src" > output="bin" path=""/> > 33: <classpathentry kind="output" path="bin"/> > 34: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/swing"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry excluding=".classpath|.project|.settings" kind="src" output="bin" path=""/> <classpathentry kind="output" path="bin"/> </classpath> tests/manual/events/.classpath line 23: > 21: <classpathentry excluding=".classpath|.project|.settings" kind="src" > output="bin" path=""/> > 22: <classpathentry kind="output" path="bin"/> > 23: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry excluding=".classpath|.project|.settings" kind="src" output="bin" path=""/> <classpathentry kind="output" path="bin"/> </classpath> tests/manual/graphics/.classpath line 29: > 27: <classpathentry excluding=".classpath|.project|.settings" kind="src" > output="bin" path=""/> > 28: <classpathentry kind="output" path="bin"/> > 29: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry excluding=".classpath|.project|.settings" kind="src" output="bin" path=""/> <classpathentry kind="output" path="bin"/> </classpath> tests/manual/media/.classpath line 34: > 32: <classpathentry kind="src" output="bin" path="FXMediaPlayer/src"/> > 33: <classpathentry kind="output" path="bin"/> > 34: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/media"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="src" output="bin" path="FXMediaPlayer/src"/> <classpathentry kind="output" path="bin"/> </classpath> tests/manual/printing/.classpath line 35: > 33: <classpathentry excluding=".classpath|.project|.settings" kind="src" > output="bin" path=""/> > 34: <classpathentry kind="output" path="bin"/> > 35: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/web"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry excluding=".classpath|.project|.settings" kind="src" output="bin" path=""/> <classpathentry kind="output" path="bin"/> </classpath> tests/manual/swing/.classpath line 34: > 32: <classpathentry excluding=".classpath|.project|.settings" kind="src" > output="bin" path=""/> > 33: <classpathentry kind="output" path="bin"/> > 34: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/swing"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry excluding=".classpath|.project|.settings" kind="src" output="bin" path=""/> <classpathentry kind="output" path="bin"/> </classpath> tests/manual/swt/.classpath line 39: > 37: <classpathentry excluding=".classpath|.project|.settings" kind="src" > output="bin" path=""/> > 38: <classpathentry kind="output" path="bin"/> > 39: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/swt"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="lib" path="../../../build/libs/swt-debug.jar"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry excluding=".classpath|.project|.settings" kind="src" output="bin" path=""/> <classpathentry kind="output" path="bin"/> </classpath> tests/manual/text/.classpath line 23: > 21: <classpathentry excluding=".classpath|.project|.settings" kind="src" > output="bin" path=""/> > 22: <classpathentry kind="output" path="bin"/> > 23: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry excluding=".classpath|.project|.settings" kind="src" output="bin" path=""/> <classpathentry kind="output" path="bin"/> </classpath> tests/manual/web/.classpath line 35: > 33: <classpathentry excluding=".classpath|.project|.settings" kind="src" > output="bin" path=""/> > 34: <classpathentry kind="output" path="bin"/> > 35: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/web"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry excluding=".classpath|.project|.settings" kind="src" output="bin" path=""/> <classpathentry kind="output" path="bin"/> </classpath> tests/system/src/testapp1/.classpath line 29: > 27: <classpathentry kind="src" output="bin" path="java"/> > 28: <classpathentry kind="output" path="bin"/> > 29: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="src" output="bin" path="java"/> <classpathentry kind="output" path="bin"/> </classpath> tests/system/src/testapp2/.classpath line 29: > 27: <classpathentry kind="src" output="bin" path="java/mymod"/> > 28: <classpathentry kind="output" path="bin"/> > 29: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="src" output="bin" path="java/mymod"/> <classpathentry kind="output" path="bin"/> </classpath> tests/system/src/testapp3/.classpath line 29: > 27: <classpathentry kind="src" output="bin" path="java/mymod"/> > 28: <classpathentry kind="output" path="bin"/> > 29: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="src" output="bin" path="java/mymod"/> <classpathentry kind="output" path="bin"/> </classpath> tests/system/src/testapp4/.classpath line 29: > 27: <classpathentry kind="src" output="bin" path="java/mymod"/> > 28: <classpathentry kind="output" path="bin"/> > 29: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="src" output="bin" path="java/mymod"/> <classpathentry kind="output" path="bin"/> </classpath> tests/system/src/testapp5/.classpath line 35: > 33: <classpathentry kind="src" output="bin" path="java/mymod"/> > 34: <classpathentry kind="output" path="bin"/> > 35: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/web"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="src" output="bin" path="java/mymod"/> <classpathentry kind="output" path="bin"/> </classpath> tests/system/src/testapp6/.classpath line 35: > 33: <classpathentry kind="src" output="bin" path="resources/mymod"/> > 34: <classpathentry kind="output" path="bin"/> > 35: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/fxml"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="src" output="bin" path="java/mymod"/> <classpathentry kind="src" output="bin" path="resources/mymod"/> <classpathentry kind="output" path="bin"/> </classpath> tests/system/src/testapp7/.classpath line 41: > 39: <classpathentry kind="src" output="bin" path="resources/mymod"/> > 40: <classpathentry kind="output" path="bin"/> > 41: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/web"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/media"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="src" output="bin" path="java/mymod"/> <classpathentry kind="src" output="bin" path="resources/mymod"/> <classpathentry kind="output" path="bin"/> </classpath> tests/system/src/testscriptapp1/.classpath line 35: > 33: <classpathentry kind="src" output="bin" path="resources/mymod"/> > 34: <classpathentry kind="output" path="bin"/> > 35: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/fxml"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="src" output="bin" path="java/mymod"/> <classpathentry kind="src" output="bin" path="resources/mymod"/> <classpathentry kind="output" path="bin"/> </classpath> tests/system/src/testscriptapp2/.classpath line 35: > 33: <classpathentry kind="src" output="bin" path="resources/mymod"/> > 34: <classpathentry kind="output" path="bin"/> > 35: </classpath> <?xml version="1.0" encoding="UTF-8"?> <classpath> <classpathentry combineaccessrules="false" kind="src" path="/base"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/graphics"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/controls"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry combineaccessrules="false" kind="src" path="/fxml"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"> <attributes> <attribute name="module" value="true"/> </attributes> </classpathentry> <classpathentry kind="src" output="bin" path="java/mymod"/> <classpathentry kind="src" output="bin" path="resources/mymod"/> <classpathentry kind="output" path="bin"/> </classpath> ------------- Changes requested by nlisker (Reviewer). PR: https://git.openjdk.org/jfx/pull/930
