On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class definitions, or just
> repeated ones)
> - Remove redundant super interfaces (interface that is already inherited)
> - Remove unused type parameters
> - Remove declared checked exceptions that are never thrown
> - Add missing `@Override` annotations
Changes requested by angorya (Author).
modules/javafx.base/src/main/java/javafx/beans/property/IntegerPropertyBase.java
line 56:
> 54:
> 55: private int value;
> 56: private ObservableIntegerValue observable = null;;
is there an Eclipse warning for extra semicolon?
modules/javafx.base/src/main/java/javafx/beans/property/ReadOnlyBooleanProperty.java
line 168:
> 166: }
> 167: };
> 168: };
how did you find these - manually or searching for a "};" pattern?
modules/javafx.base/src/main/java/javafx/util/converter/DateStringConverter.java
line 130:
> 128:
> 129: /** {@inheritDoc} */
> 130: @SuppressWarnings("removal")
puzzling - why was it marked with @SuppressWarnings("removal") ?
modules/javafx.base/src/shims/java/javafx/event/EventTypeShim.java line 30:
> 28: import java.util.List;
> 29:
> 30: public class EventTypeShim<T extends Event> {
this changes public API surface, does it not?
modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 123:
> 121:
> 122: if (weakReference.get() == null && counter < steps / 3) {
> 123: int percentageUsed = (steps - counter) / steps * 100;
I suspect this will not produce a desired result.
Perhaps it should be
(int)(100.0 * (steps - counter) / steps);
-------------
PR: https://git.openjdk.org/jfx/pull/957
