On Mon, 21 Nov 2022 20:05:25 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Removing the `(int)` cast is a behavior-neutral change. What you are >> pointing out does look a bug, but it is unrelated to this cleanup, so should >> be filed and fixed separately. > > Yeah, this looks like a bug, as `(steps - counter) / steps` which are all > `int`s will likely always result in `0`. The cast removal here however does > not alter the calculation, but does point to an error in the author's thought > process. The result is however only used in the log message to inform of a > problem, and so the logic is not otherwise affected. > > I can file a separate issue for this, unless we can agree to fix it as part > of this clean-up. cc: @FlorianKirmaier ------------- PR: https://git.openjdk.org/jfx/pull/957