On Mon, 28 Nov 2022 14:49:12 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Lukasz Kostyra has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Merge branch 'master' of https://git.openjdk.org/jfx into >> JDK-8265828-locale >> - Refactor remaining LocalStringConverter tests >> >> Treatment done in this commit is similar to the previous change. >> - LocalDateTimeStringConverterTest: Refactor test to properly utilize Locale >> >> * Locale initialization was moved to @BeforeClass method. >> * DateTimeFormatter objects are allocated after Locale initialization >> * Since LocalDateTimeStringConverter depends on DateTimeFormatter and on >> VM's Locale, >> creation of it was moved to @Before method. >> - 8265828: [TestBug] Save and restore the default Locale in javafx.base >> unit test LocalDateTimeStringConverterTest > > modules/javafx.base/src/test/java/test/javafx/util/converter/LocalDateStringConverterTest.java > line 123: > >> 121: @Before >> 122: public void setup() { >> 123: if (this.converter == null) { > > There is no need to check for `null` here. It always will be, since > `converter` is initialized to `null` in the constructor and there is no other > assignment. Done, also fixed in other files ------------- PR: https://git.openjdk.org/jfx/pull/954
