On Tue, 29 Nov 2022 11:34:02 GMT, Lukasz Kostyra <d...@openjdk.org> wrote:

>> The change moves Locale setting in the test to `@BeforeClass` and 
>> `@AfterClass` calls. `@BeforeClass` method call stores current default VM 
>> locale and applies Locale.US, while `@AfterClass` method restores old VM 
>> locale after all tests are completed.
>> 
>> I tested it both on Mac and Windows, in both cases Locale is changed, 
>> restored properly and tests pass.
>
> Lukasz Kostyra has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix code review comments

Looks good. You can remove the now-unused import of 
`java.security.InvalidParameterException` (I'll reapprove when you do).

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/954

Reply via email to