> This fixes a bug where the first call to unbind would clear the internal > invalidation listener used, resulting in subsequent unbind calls to be > no-ops, unless bind was called again first. > > I had to rewrite the parameterized test slightly as Parameterized will only > call the parameters method once, and my new test modifies the internal state > of the bindings used as parameters (by doing some unbind calls) which was > making other tests fail.
John Hendrikx has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' of https://git.openjdk.org/jfx into feature/unbind - 8243115: Unregister bindings when unbind called multiple times This fixes a bug where the first call to unbind would clear the internal invalidation listener used, resulting in subsequent unbind calls to be no-ops, unless bind was called again first. ------------- Changes: - all: https://git.openjdk.org/jfx/pull/198/files - new: https://git.openjdk.org/jfx/pull/198/files/e3095db3..011017b7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=198&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=198&range=00-01 Stats: 2030609 lines in 18328 files changed: 1087981 ins; 691043 del; 251585 mod Patch: https://git.openjdk.org/jfx/pull/198.diff Fetch: git fetch https://git.openjdk.org/jfx pull/198/head:pull/198 PR: https://git.openjdk.org/jfx/pull/198
