On Tue, 3 Jan 2023 09:54:42 GMT, John Hendrikx <[email protected]> wrote:
>> This fixes a bug where the first call to unbind would clear the internal >> invalidation listener used, resulting in subsequent unbind calls to be >> no-ops, unless bind was called again first. >> >> I had to rewrite the parameterized test slightly as Parameterized will only >> call the parameters method once, and my new test modifies the internal state >> of the bindings used as parameters (by doing some unbind calls) which was >> making other tests fail. > > John Hendrikx has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' of https://git.openjdk.org/jfx into feature/unbind > - 8243115: Unregister bindings when unbind called multiple times > > This fixes a bug where the first call to unbind would clear the internal > invalidation listener used, resulting in subsequent unbind calls to be > no-ops, unless bind was called again first. The patch looks good, and I can confirm that it fixes the bug. ------------- Marked as reviewed by mstrauss (Committer). PR: https://git.openjdk.org/jfx/pull/198
