> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after 
> expand/collapse events. The graphics node needs to be released from the 
> previous checkbox so that it doesn't serve as the graphics of more than one 
> checkbox at once. If it does, only one checkbox (its skin) can actually use 
> it as a scenegraph child, and it's not always the correct one.
> 
> Added also a manual test app as I'm unsure about how to do an automatic test 
> for this. The test app will be useful for later fixes, so I suggest adding it 
> anyway. To test the fix, simply expand and collapse the root note repeatedly 
> while it has a child. Before the fix the graphic will disappear after a few 
> tries, after the fix it won't. You can test other hierarchies as well by 
> adding children to the tree.

Nir Lisker has updated the pull request incrementally with one additional 
commit since the last revision:

  Added copyright header and changed package name

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/970/files
  - new: https://git.openjdk.org/jfx/pull/970/files/b1808afe..4d89b0da

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=970&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=970&range=00-01

  Stats: 203 lines in 2 files changed: 114 ins; 89 del; 0 mod
  Patch: https://git.openjdk.org/jfx/pull/970.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/970/head:pull/970

PR: https://git.openjdk.org/jfx/pull/970

Reply via email to