On Tue, 3 Jan 2023 23:38:10 GMT, Nir Lisker <[email protected]> wrote:
>> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after
>> expand/collapse events. The graphics node needs to be released from the
>> previous checkbox so that it doesn't serve as the graphics of more than one
>> checkbox at once. If it does, only one checkbox (its skin) can actually use
>> it as a scenegraph child, and it's not always the correct one.
>>
>> Added also a manual test app as I'm unsure about how to do an automatic test
>> for this. The test app will be useful for later fixes, so I suggest adding
>> it anyway. To test the fix, simply expand and collapse the root note
>> repeatedly while it has a child. Before the fix the graphic will disappear
>> after a few tries, after the fix it won't. You can test other hierarchies as
>> well by adding children to the tree.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added copyright header and changed package name
I verified that the test shows the problem without the fix and it looks good
with the fix.
I left one more minor comment on the test.
tests/performance/checkboxTreeView/src/main/java/main/CheckBoxTreeEditor.java
line 49:
> 47:
> 48: @Override
> 49: public void start(Stage stage) throws IOException {
Minor: nothing in this program can throw IOE, so this could be removed (along
with the import).
-------------
PR: https://git.openjdk.org/jfx/pull/970
