On Mon, 30 Jan 2023 21:56:45 GMT, Alexander Zuev <[email protected]> wrote:
> Change the underlying class XYChart to take into account labels for axes.
> Make label patterns and default axes labels localized.
My initial testing (on Windows) looks good. I have a general question in
addition to the one inline comment. Since you added new i18n resource strings
have you verified that it works for other locales to ensure no regression? (it
should just speak the English string, since there are no translated strings yet)
As for the implementation, I see you've added a (private) shadow property for
the x and y axes and the series, as opposed to making them actual properties
with only the getter being exposed publicly. As long as the fields are only
ever set via the setter method, I think it should work fine the way you have
it, but want to take a second look.
modules/javafx.controls/src/main/java/javafx/scene/chart/XYChart.java line 1403:
> 1401: Object[] args = {seriesName, xAxisName,
> getCurrentX(), yAxisName, getCurrentY()};
> 1402: String retVal = mf.format(args);
> 1403: System.out.println("result = " + retVal);
You'll need to remove this debug print statement.
-------------
PR: https://git.openjdk.org/jfx/pull/1016
