On Fri, 3 Feb 2023 14:09:08 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> sorry to hold up the review - I'll speak to Naoto Sato tomorrow (2/3/23 @ >> 11:00) regarding the requirements for translation hints, and either approve >> or let you know what they expect us to do. > > OK. Presuming that the comment Alex already left is fine, or just needs a > slight format change, then that's good. If it's more than that, it would be > better to do it in a follow-up issue. The comment is good. The idea of giving translators hints in the form of comments like this was very warmly welcomed by our i18n lead Naoto Sato. So I think we should follow this approach for every new string we add in jfx (and jdk). The goal is to give the translators more context, by either giving an example of resulting text or by describing the parameters like Alex did in this case (or both). ------------- PR: https://git.openjdk.org/jfx/pull/1016
