On Mon, 6 Feb 2023 13:33:20 GMT, Karthik P K <[email protected]> wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present for all the ContentDisplay types. Modified tests which
>> were failing because of the new height value getting calculated.
>
> Karthik P K has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Code optimization
Marked as reviewed by jhendrikx (Committer).
modules/javafx.controls/src/main/java/javafx/scene/control/skin/LabeledSkinBase.java
line 331:
> 329:
> 330: double width;
> 331: if(isIgnoreGraphic()) {
minor: missed a space here after `if`
modules/javafx.controls/src/main/java/javafx/scene/control/skin/LabeledSkinBase.java
line 393:
> 391: if (isIgnoreText()) {
> 392: height = graphicHeight;
> 393: } else if (contentDisplay == TOP || contentDisplay ==
> BOTTOM){
minor: missing space before `{`
-------------
PR: https://git.openjdk.org/jfx/pull/996
