On Tue, 7 Feb 2023 05:25:08 GMT, Karthik P K <k...@openjdk.org> wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while >> calculating the Label height. >> >> Added `isIgnoreText` condition in `computePrefHeight` method while >> calculating Label height. >> >> Tests are present for all the ContentDisplay types. Modified tests which >> were failing because of the new height value getting calculated. > > Karthik P K has updated the pull request incrementally with one additional > commit since the last revision: > > Addressing review comments modules/javafx.controls/src/main/java/javafx/scene/control/skin/LabeledSkinBase.java line 365: > 363: } > 364: > 365: String cleanText = getCleanText(); cleanText code block is unnecessary when isIgnoreText() == true ------------- PR: https://git.openjdk.org/jfx/pull/996
