On Wed, 8 Feb 2023 12:19:34 GMT, Karthik P K <k...@openjdk.org> wrote:

>> Ignore text condition was not considered in `computePrefHeight` method while 
>> calculating the Label height.
>> 
>> Added `isIgnoreText` condition in `computePrefHeight` method while 
>> calculating Label height.
>> 
>> Tests are present for all the ContentDisplay types. Modified tests which 
>> were failing because of the new height value getting calculated.
>
> Karthik P K has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressing review comments

I'd recommend to make further optimizations, see the code sample.

For your convenience, I've added a Label page to the monkey tester
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/monkey/MonkeyTesterApp.java

(sorry, it is still in a separate repository.  if you use Eclipse, just import 
the project into your workspace)

-------------

PR: https://git.openjdk.org/jfx/pull/996

Reply via email to